Build JSI, React-Debug and React-logger with SPM#50075
Closed
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Closed
Build JSI, React-Debug and React-logger with SPM#50075cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
cipolleschi
force-pushed
the
export-D70567840
branch
from
dd826b2 to
bf123ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
cipolleschi
force-pushed
the
export-D70567840
branch
from
bf123ae to
eb7e28d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
cipolleschi
force-pushed
the
export-D70567840
branch
from
eb7e28d to
ab4c9d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
cipolleschi
force-pushed
the
export-D70567840
branch
from
ab4c9d1 to
b8b3c3e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
…ook#50075) Summary: This is an exploratory change to see how it will look like to build core from SPM. In this change we are building three pieces of React native (using the Podspec names for simplicity): - React-jsi - React-debug - React-logger - React-MapBuffer They depends on a local ReactNativeDependency.xcframework we can build using the prebuild-io script. ## CHANGELOG: [INTERNAL] - set up initial Swift PM configuration Reviewed By: cortinico Differential Revision: D70567840
cipolleschi
force-pushed
the
export-D70567840
branch
from
b8b3c3e to
89de696
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70567840 |
Contributor
|
This pull request has been merged in 65bcfda. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 65bcfda When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is an exploratory change to see how it will look like to build core from SPM.
In this change we are building three pieces of React native (using the Podspec names for simplicity):
They depends on a local ReactNativeDependency.xcframework we can build using the prebuild-io script.
CHANGELOG:
[INTERNAL] - set up initial Swift PM configuration
Differential Revision: D70567840
Test Plan:
You can build the Swift PM project with the command:
The last instruction will create a build folder on the Desktop.
The content of the build folder is the following:
You can see that it contains the react frmaework plus all the
.ofiles for the three target we are building.